From 2c9feef4cdc869e0040338178b0d36c09684137e Mon Sep 17 00:00:00 2001 From: Debasish Ghosh Date: Sat, 13 Nov 2010 22:02:35 +0530 Subject: [PATCH] Fixed Issue 528 - RedisPersistentRef should not throw in case of missing key --- .../src/main/scala/RedisStorageBackend.scala | 3 --- .../src/test/scala/RedisStorageBackendSpec.scala | 16 +--------------- 2 files changed, 1 insertion(+), 18 deletions(-) diff --git a/akka-persistence/akka-persistence-redis/src/main/scala/RedisStorageBackend.scala b/akka-persistence/akka-persistence-redis/src/main/scala/RedisStorageBackend.scala index af620c446c..df7a1feab4 100644 --- a/akka-persistence/akka-persistence-redis/src/main/scala/RedisStorageBackend.scala +++ b/akka-persistence/akka-persistence-redis/src/main/scala/RedisStorageBackend.scala @@ -248,9 +248,6 @@ private [akka] object RedisStorageBackend extends def getRefStorageFor(name: String): Option[Array[Byte]] = withErrorHandling { db.get(name) .map(stringToByteArray(_)) - .orElse { - throw new NoSuchElementException(name + " not present") - } } // add to the end of the queue diff --git a/akka-persistence/akka-persistence-redis/src/test/scala/RedisStorageBackendSpec.scala b/akka-persistence/akka-persistence-redis/src/test/scala/RedisStorageBackendSpec.scala index da193aac16..699c4ea60e 100644 --- a/akka-persistence/akka-persistence-redis/src/test/scala/RedisStorageBackendSpec.scala +++ b/akka-persistence/akka-persistence-redis/src/test/scala/RedisStorageBackendSpec.scala @@ -153,6 +153,7 @@ class RedisStorageBackendSpec extends insertRefStorageFor("T-4", "1200".getBytes) new String(getRefStorageFor("T-4").get) should equal("1200") + getRefStorageFor("T-44") should equal(None) } it("should write a Name object and fetch it properly") { val dtb = Calendar.getInstance.getTime @@ -226,21 +227,6 @@ class RedisStorageBackendSpec extends u.map{ case (e, s) => new String(e) } should equal(sorted) } } - - describe("store and query test in sorted set") { - it("should give proper sorted set semantics") { - zadd("hckers", "1965", "yukihiro matsumoto".getBytes) - zadd("hckers", "1953", "richard stallman".getBytes) - zadd("hckers", "1916", "claude shannon".getBytes) - zadd("hckers", "1969", "linus torvalds".getBytes) - zadd("hckers", "1940", "alan kay".getBytes) - zadd("hckers", "1912", "alan turing".getBytes) - zadd("hckers", "1912", "debasish ghosh".getBytes) - println(zcard("hckers")) - println(zrange("hckers", 0, -1)) - } - } - } object NameSerialization {