deprecate closure-taking Props factories, see #3081

- base Props on Deploy, Class and Seq[Any] (i.e. constructor args)
- remove deprecated Props usage from akka-docs sample code
- rewrite UntypedActorDocTestBase
- rewrite Java/Scala doc section on actor creation
- add migration guide entry

akka-docs/rst/scala/code/docs/camel/CustomRouteExample.scala

@@ -44,8 +44,8 @@ object CustomRouteExample {
     // example from a MicroKernel
     val system = ActorSystem("some-system")
     val producer = system.actorOf(Props[Producer1])
-    val mediator = system.actorOf(Props(new Transformer(producer)))
-    val consumer = system.actorOf(Props(new Consumer3(mediator)))
+    val mediator = system.actorOf(Props(classOf[Transformer], producer))
+    val consumer = system.actorOf(Props(classOf[Consumer3], mediator))
     CamelExtension(system).context.addRoutes(new CustomRouteBuilder)
     //#CustomRouteExample
   }

akka-docs/rst/scala/code/docs/camel/HttpExample.scala

@@ -43,8 +43,8 @@ object HttpExample {
     // to your boot class.
     val system = ActorSystem("some-system")
     val httpTransformer = system.actorOf(Props[HttpTransformer])
-    val httpProducer = system.actorOf(Props(new HttpProducer(httpTransformer)))
-    val httpConsumer = system.actorOf(Props(new HttpConsumer(httpProducer)))
+    val httpProducer = system.actorOf(Props(classOf[HttpProducer], httpTransformer))
+    val httpConsumer = system.actorOf(Props(classOf[HttpConsumer], httpProducer))
     //#HttpExample
 
   }

akka-docs/rst/scala/code/docs/camel/Producers.scala

@@ -45,8 +45,8 @@ object Producers {
     }
     val system = ActorSystem("some-system")
     val receiver = system.actorOf(Props[ResponseReceiver])
-    val forwardResponse = system.actorOf(Props(
-      new Forwarder("http://localhost:8080/news/akka", receiver)))
+    val forwardResponse = system.actorOf(
+      Props(classOf[Forwarder], this, "http://localhost:8080/news/akka", receiver))
     // the Forwarder sends out a request to the web page and forwards the response to
     // the ResponseReceiver
     forwardResponse ! "some request"
@@ -81,7 +81,7 @@ object Producers {
     }
 
     val system = ActorSystem("some-system")
-    val producer = system.actorOf(Props(new OnewaySender("activemq:FOO.BAR")))
+    val producer = system.actorOf(Props(classOf[OnewaySender], this, "activemq:FOO.BAR"))
     producer ! "Some message"
     //#Oneway
 

akka-docs/rst/scala/code/docs/camel/PublishSubscribe.scala

@@ -1,47 +1,44 @@
 package docs.camel
 
 object PublishSubscribe {
-  {
-    //#PubSub
-    import akka.actor.{ Actor, ActorRef, ActorSystem, Props }
-    import akka.camel.{ Producer, CamelMessage, Consumer }
+  //#PubSub
+  import akka.actor.{ Actor, ActorRef, ActorSystem, Props }
+  import akka.camel.{ Producer, CamelMessage, Consumer }
 
-    class Subscriber(name: String, uri: String) extends Actor with Consumer {
-      def endpointUri = uri
+  class Subscriber(name: String, uri: String) extends Actor with Consumer {
+    def endpointUri = uri
 
-      def receive = {
-        case msg: CamelMessage ⇒ println("%s received: %s" format (name, msg.body))
-      }
+    def receive = {
+      case msg: CamelMessage ⇒ println("%s received: %s" format (name, msg.body))
     }
-
-    class Publisher(name: String, uri: String) extends Actor with Producer {
-
-      def endpointUri = uri
-
-      // one-way communication with JMS
-      override def oneway = true
-    }
-
-    class PublisherBridge(uri: String, publisher: ActorRef) extends Actor with Consumer {
-      def endpointUri = uri
-
-      def receive = {
-        case msg: CamelMessage ⇒ {
-          publisher ! msg.bodyAs[String]
-          sender ! ("message published")
-        }
-      }
-    }
-
-    // Add below to a Boot class
-    // Setup publish/subscribe example
-    val system = ActorSystem("some-system")
-    val jmsUri = "jms:topic:test"
-    val jmsSubscriber1 = system.actorOf(Props(new Subscriber("jms-subscriber-1", jmsUri)))
-    val jmsSubscriber2 = system.actorOf(Props(new Subscriber("jms-subscriber-2", jmsUri)))
-    val jmsPublisher = system.actorOf(Props(new Publisher("jms-publisher", jmsUri)))
-    val jmsPublisherBridge = system.actorOf(Props(new PublisherBridge("jetty:http://0.0.0.0:8877/camel/pub/jms", jmsPublisher)))
-    //#PubSub
-
   }
+
+  class Publisher(name: String, uri: String) extends Actor with Producer {
+
+    def endpointUri = uri
+
+    // one-way communication with JMS
+    override def oneway = true
+  }
+
+  class PublisherBridge(uri: String, publisher: ActorRef) extends Actor with Consumer {
+    def endpointUri = uri
+
+    def receive = {
+      case msg: CamelMessage ⇒ {
+        publisher ! msg.bodyAs[String]
+        sender ! ("message published")
+      }
+    }
+  }
+
+  // Add below to a Boot class
+  // Setup publish/subscribe example
+  val system = ActorSystem("some-system")
+  val jmsUri = "jms:topic:test"
+  val jmsSubscriber1 = system.actorOf(Props(classOf[Subscriber], "jms-subscriber-1", jmsUri))
+  val jmsSubscriber2 = system.actorOf(Props(classOf[Subscriber], "jms-subscriber-2", jmsUri))
+  val jmsPublisher = system.actorOf(Props(classOf[Publisher], "jms-publisher", jmsUri))
+  val jmsPublisherBridge = system.actorOf(Props(classOf[PublisherBridge], "jetty:http://0.0.0.0:8877/camel/pub/jms", jmsPublisher))
+  //#PubSub
 }