deprecate closure-taking Props factories, see #3081

- base Props on Deploy, Class and Seq[Any] (i.e. constructor args)
- remove deprecated Props usage from akka-docs sample code
- rewrite UntypedActorDocTestBase
- rewrite Java/Scala doc section on actor creation
- add migration guide entry

akka-docs/rst/java/code/docs/camel/ActivationTestBase.java

@@ -9,7 +9,6 @@ package docs.camel;
     import akka.util.Timeout;
     import scala.concurrent.Future;
     import scala.concurrent.duration.Duration;
-    import scala.concurrent.duration.FiniteDuration;
     import static java.util.concurrent.TimeUnit.SECONDS;
 //#CamelActivation
 
@@ -17,13 +16,14 @@ import org.junit.Test;
 
 public class ActivationTestBase {
 
+  @SuppressWarnings("unused")
   @Test
   public void testActivation() {
     //#CamelActivation
 
     // ..
     ActorSystem system = ActorSystem.create("some-system");
-    Props props = new Props(MyConsumer.class);
+    Props props = Props.create(MyConsumer.class);
     ActorRef producer = system.actorOf(props,"myproducer");
     Camel camel = CamelExtension.get(system);
     // get a future reference to the activation of the endpoint of the Consumer Actor

akka-docs/rst/java/code/docs/camel/CustomRouteTestBase.java

@@ -11,7 +11,7 @@ public class CustomRouteTestBase {
     //#CustomRoute
     ActorSystem system = ActorSystem.create("some-system");
     Camel camel = CamelExtension.get(system);
-    ActorRef responder = system.actorOf(new Props(Responder.class), "TestResponder");
+    ActorRef responder = system.actorOf(Props.create(Responder.class), "TestResponder");
     camel.context().addRoutes(new CustomRouteBuilder(responder));
     //#CustomRoute
     system.stop(responder);

akka-docs/rst/java/code/docs/camel/OnRouteResponseTestBase.java

@@ -7,14 +7,10 @@ public class OnRouteResponseTestBase {
   public void onRouteResponse(){
     //#RouteResponse
     ActorSystem system = ActorSystem.create("some-system");
-    Props receiverProps = new Props(ResponseReceiver.class);
+    Props receiverProps = Props.create(ResponseReceiver.class);
     final ActorRef receiver = system.actorOf(receiverProps,"responseReceiver");
-    UntypedActorFactory factory = new UntypedActorFactory() {
-      public Actor create() {
-        return new Forwarder("http://localhost:8080/news/akka", receiver);
-      }
-    };
-    ActorRef forwardResponse = system.actorOf(new Props(factory));
+    ActorRef forwardResponse = system.actorOf(Props.create(
+        Forwarder.class, "http://localhost:8080/news/akka", receiver));
     // the Forwarder sends out a request to the web page and forwards the response to
     // the ResponseReceiver
     forwardResponse.tell("some request", null);

akka-docs/rst/java/code/docs/camel/ProducerTestBase.java

@@ -14,17 +14,18 @@ public class ProducerTestBase {
   public void tellJmsProducer() {
     //#TellProducer
     ActorSystem system = ActorSystem.create("some-system");
-    Props props = new Props(Orders.class);
+    Props props = Props.create(Orders.class);
     ActorRef producer = system.actorOf(props, "jmsproducer");
     producer.tell("<order amount=\"100\" currency=\"PLN\" itemId=\"12345\"/>", null);
     //#TellProducer
     system.shutdown();
   }
 
+  @SuppressWarnings("unused")
   public void askProducer() {
     //#AskProducer
     ActorSystem system = ActorSystem.create("some-system");
-    Props props = new Props(FirstProducer.class);
+    Props props = Props.create(FirstProducer.class);
     ActorRef producer = system.actorOf(props,"myproducer");
     Future<Object> future = Patterns.ask(producer, "some request", 1000);
     //#AskProducer
@@ -35,7 +36,7 @@ public class ProducerTestBase {
   public void correlate(){
     //#Correlate
     ActorSystem system = ActorSystem.create("some-system");
-    Props props = new Props(Orders.class);
+    Props props = Props.create(Orders.class);
     ActorRef producer = system.actorOf(props,"jmsproducer");
     Map<String,Object> headers = new HashMap<String, Object>();
     headers.put(CamelMessage.MessageExchangeId(),"123");

akka-docs/rst/java/code/docs/camel/sample/http/HttpSample.java

@@ -9,19 +9,15 @@ public class HttpSample {
     // run the example in the MicroKernel. Just add the three lines below
     // to your boot class.
     ActorSystem system = ActorSystem.create("some-system");
-    final ActorRef httpTransformer = system.actorOf(new Props(HttpTransformer.class));
+    
+    final ActorRef httpTransformer = system.actorOf(
+        Props.create(HttpTransformer.class));
 
-    final ActorRef httpProducer = system.actorOf(new Props(new UntypedActorFactory(){
-      public Actor create() {
-        return new HttpProducer(httpTransformer);
-      }
-    }));
-
-    ActorRef httpConsumer = system.actorOf(new Props(new UntypedActorFactory(){
-      public Actor create() {
-        return new HttpConsumer(httpProducer);
-      }
-    }));
+    final ActorRef httpProducer = system.actorOf(
+        Props.create(HttpProducer.class, httpTransformer));
+    
+    final ActorRef httpConsumer = system.actorOf(
+        Props.create(HttpConsumer.class, httpProducer));
     //#HttpExample
   }
 }

akka-docs/rst/java/code/docs/camel/sample/quartz/QuartzSample.java

@@ -6,7 +6,7 @@ import akka.actor.Props;
 public class QuartzSample {
   public static void main(String[] args) {
     ActorSystem system = ActorSystem.create("my-quartz-system");
-    system.actorOf(new Props(MyQuartzActor.class));
+    system.actorOf(Props.create(MyQuartzActor.class));
   }
 }
 //#QuartzExample

akka-docs/rst/java/code/docs/camel/sample/route/CustomRouteSample.java

@@ -4,25 +4,16 @@ import akka.actor.*;
 import akka.camel.CamelExtension;
 
 public class CustomRouteSample {
+  @SuppressWarnings("unused")
   public static void main(String[] args) {
     try {
       //#CustomRouteExample
       // the below lines can be added to a Boot class, so that you can run the
       // example from a MicroKernel
       ActorSystem system = ActorSystem.create("some-system");
-      final ActorRef producer = system.actorOf(new Props(Producer1.class));
-      final ActorRef mediator = system.actorOf(new Props(new UntypedActorFactory() {
-        public Actor create() {
-          return new Transformer(producer);
-
-        }
-      }));
-      ActorRef consumer = system.actorOf(new Props(new UntypedActorFactory() {
-        public Actor create() {
-          return new Consumer3(mediator);
-
-        }
-      }));
+      final ActorRef producer = system.actorOf(Props.create(Producer1.class));
+      final ActorRef mediator = system.actorOf(Props.create(Transformer.class, producer));
+      final ActorRef consumer = system.actorOf(Props.create(Consumer3.class, mediator));
       CamelExtension.get(system).context().addRoutes(new CustomRouteBuilder());
       //#CustomRouteExample
     } catch (Exception e) {