Refactor exception handling in StatusReplyTest (#30081)

* Refactor exception handling in StatusReplyTest

* Change messages in assertThrows

akka-actor-tests/src/test/java/akka/pattern/StatusReplyTest.java

@@ -30,53 +30,41 @@ public class StatusReplyTest extends JUnitSuite {
       new AkkaJUnitActorSystemResource("JavaAPI", AkkaSpec.testConf());
 
   @Test
-  public void testSuccessApi() {
+  public void successReplyThrowsExceptionWhenGetErrorIsCalled() {
     StatusReply<String> reply = StatusReply.success("woho");
     assertTrue(reply.isSuccess());
     assertFalse(reply.isError());
     assertEquals("woho", reply.getValue());
-    try {
+    Assert.assertThrows(
-      reply.getError();
+        "Calling .getError() on success should throw",
-      Assert.fail("Calling get error on success did not throw");
+        IllegalArgumentException.class,
-    } catch (IllegalArgumentException ex) {
+        reply::getError);
-      // this is what we expect
-    }
   }
 
   @Test
-  public void testErrorMessageApi() {
+  public void failedReplyThrowsExceptionWhenGetValueIsCalled() {
     StatusReply<String> reply = StatusReply.error("boho");
     assertTrue(reply.isError());
     assertFalse(reply.isSuccess());
     assertEquals("boho", reply.getError().getMessage());
-    try {
+    Assert.assertThrows(
-      reply.getValue();
+        "Calling .getValue() on error should throw",
-      Assert.fail("Calling get value on error did not throw");
+        StatusReply.ErrorMessage.class,
-    } catch (StatusReply.ErrorMessage ex) {
+        reply::getValue);
-      // this is what we expect
-    } catch (Throwable th) {
-      Assert.fail("Unexpected exception type: " + th);
-    }
   }
 
   @Test
-  public void testErrorExceptionApi() {
+  public void failedReplyThrowsOriginalExceptionWhenGetValueIsCalled() {
     StatusReply<String> reply = StatusReply.error(new TestException("boho"));
     assertTrue(reply.isError());
     assertFalse(reply.isSuccess());
     assertEquals("boho", reply.getError().getMessage());
-    try {
+    Assert.assertThrows(
-      reply.getValue();
+        "Calling .getValue() on error should throw", TestException.class, reply::getValue);
-      Assert.fail("Calling get value on error did not throw");
-    } catch (TestException ex) {
-      // this is what we expect
-    } catch (Throwable th) {
-      Assert.fail("Unexpected exception type: " + th);
-    }
   }
 
   @Test
-  public void testAskWithStatusSuccess() throws Exception {
+  public void askWithStatusSuccessReturnsValue() throws Exception {
     TestProbe probe = new TestProbe(actorSystemResource.getSystem());
 
     CompletionStage<Object> response = askWithStatus(probe.ref(), "request", Duration.ofSeconds(3));
@@ -88,36 +76,32 @@ public class StatusReplyTest extends JUnitSuite {
   }
 
   @Test
-  public void testAskWithStatusErrorMessage() throws Exception {
+  public void askWithStatusErrorReturnsErrorMessageExceptionForText() {
     TestProbe probe = new TestProbe(actorSystemResource.getSystem());
 
     CompletionStage<Object> response = askWithStatus(probe.ref(), "request", Duration.ofSeconds(3));
     probe.expectMsg("request");
     probe.lastSender().tell(StatusReply.error("boho"), ActorRef.noSender());
-
+    ExecutionException ex =
-    try {
+        Assert.assertThrows(
-      Object result = response.toCompletableFuture().get(3, TimeUnit.SECONDS);
+            ExecutionException.class,
-    } catch (ExecutionException ex) {
+            () -> response.toCompletableFuture().get(3, TimeUnit.SECONDS));
-      // what we expected
+    assertEquals(StatusReply.ErrorMessage.class, ex.getCause().getClass());
-      assertEquals(StatusReply.ErrorMessage.class, ex.getCause().getClass());
+    assertEquals("boho", ex.getCause().getMessage());
-      assertEquals("boho", ex.getCause().getMessage());
-    }
   }
 
   @Test
-  public void testAskWithStatusErrorException() throws Exception {
+  public void askWithStatusErrorReturnsOriginalException() {
     TestProbe probe = new TestProbe(actorSystemResource.getSystem());
 
     CompletionStage<Object> response = askWithStatus(probe.ref(), "request", Duration.ofSeconds(3));
     probe.expectMsg("request");
     probe.lastSender().tell(StatusReply.error(new TestException("boho")), ActorRef.noSender());
-
+    ExecutionException ex =
-    try {
+        Assert.assertThrows(
-      Object result = response.toCompletableFuture().get(3, TimeUnit.SECONDS);
+            ExecutionException.class,
-    } catch (ExecutionException ex) {
+            () -> response.toCompletableFuture().get(3, TimeUnit.SECONDS));
-      // what we expected
+    assertEquals(TestException.class, ex.getCause().getClass());
-      assertEquals(TestException.class, ex.getCause().getClass());
+    assertEquals("boho", ex.getCause().getMessage());
-      assertEquals("boho", ex.getCause().getMessage());
-    }
   }
 }

akka-cluster-tools/src/multi-jvm/scala/akka/cluster/singleton/ClusterSingletonManagerPreparingForShutdownSpec.scala

@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2009-2020 Lightbend Inc. <https://www.lightbend.com>
+ * Copyright (C) 2009-2021 Lightbend Inc. <https://www.lightbend.com>
  */
 
 package akka.cluster.singleton