raboof/pekko
1
0
Fork 0
Code Issues Pull requests Projects Releases 6 Packages Wiki Activity Actions 11

Fail fast on empty string persistenceId in PersistentActor (#24239)

Browse source
This commit is contained in:
Nafer Sanabria 2018-01-03 16:22:44 -05:00 • committed by Konrad `ktoso` Malawski
parent 5a66976683
commit 1dffa344c4
2 changed files with 15 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
akka-persistence/src/main/scala/akka/persistence/Eventsourced.scala
View file

@ -194,6 +194,7 @@ private[persistence] trait Eventsourced extends Snapshotter with PersistenceStas
/** INTERNAL API. */ /** INTERNAL API. */
override protected[akka] def aroundPreStart(): Unit = { override protected[akka] def aroundPreStart(): Unit = {
require(persistenceId ne null, s"persistenceId is [null] for PersistentActor [${self.path}]") require(persistenceId ne null, s"persistenceId is [null] for PersistentActor [${self.path}]")
require(persistenceId.trim.nonEmpty, s"persistenceId cannot be empty for PersistentActor [${self.path}]")
// Fail fast on missing plugins. // Fail fast on missing plugins.
val j = journal; val s = snapshotStore val j = journal; val s = snapshotStore

14
akka-persistence/src/test/scala/akka/persistence/PersistentActorSpec.scala
View file

@ -692,6 +692,20 @@ abstract class PersistentActorSpec(config: Config) extends PersistenceSpec(confi
} }
} }
} }
"fail fast if persistenceId is an empty string" in {
import akka.testkit.filterEvents
filterEvents(EventFilter[ActorInitializationException]()) {
EventFilter.error(message = "persistenceId cannot be empty for PersistentActor") intercept {
val ref = system.actorOf(Props(new NamedPersistentActor(" ") {
override def receiveRecover: Receive = Actor.emptyBehavior
override def receiveCommand: Receive = Actor.emptyBehavior
}))
watch(ref)
expectTerminated(ref)
}
}
}
"recover from persisted events" in { "recover from persisted events" in {
val persistentActor = namedPersistentActor[Behavior1PersistentActor] val persistentActor = namedPersistentActor[Behavior1PersistentActor]
persistentActor ! GetState persistentActor ! GetState