Moved example code, fixed indentation in SupervisedAsk

akka-docs/rst/java/code/docs/pattern/SupervisedAsk.java

@@ -1,9 +1,12 @@
+package docs.pattern;
+
 public class SupervisedAsk {
 
   private static class AskParam {
     Props props;
     Object message;
     Timeout timeout;
+
     AskParam(Props props, Object message, Timeout timeout) {
       this.props = props;
       this.message = message;
@@ -11,7 +14,8 @@ public class SupervisedAsk {
     }
   }
 
-    private static class AskTimeout {}
+  private static class AskTimeout {
+  }
 
   public static class AskSupervisorCreator extends UntypedActor {
 
@@ -53,14 +57,16 @@ public class SupervisedAsk {
         getContext().watch(targetActor);
         targetActor.forward(askParam.message, getContext());
         Scheduler scheduler = getContext().system().scheduler();
-                timeoutMessage = scheduler.scheduleOnce(askParam.timeout.duration(), self(), new AskTimeout());
+        timeoutMessage = scheduler.scheduleOnce(askParam.timeout.duration(),
+            self(), new AskTimeout());
       } else if (message instanceof Terminated) {
         Throwable ex = new ActorKilledException("Target actor terminated.");
         caller.tell(new Status.Failure(ex));
         timeoutMessage.cancel();
         getContext().stop(self());
       } else if (message instanceof AskTimeout) {
-                Throwable ex = new TimeoutException("Target actor timed out after " + askParam.timeout.toString());
+        Throwable ex = new TimeoutException("Target actor timed out after "
+            + askParam.timeout.toString());
         caller.tell(new Status.Failure(ex));
         getContext().stop(self());
       } else
@@ -68,23 +74,14 @@ public class SupervisedAsk {
     }
   }
 
-    public static Future<Object> askOf(ActorRef supervisorCreator, 
-		Props props, Object message, Timeout timeout) {
+  public static Future<Object> askOf(ActorRef supervisorCreator, Props props,
+      Object message, Timeout timeout) {
     AskParam param = new AskParam(props, message, timeout);
     return Patterns.ask(supervisorCreator, param, timeout);
   }
 
-    synchronized public static ActorRef createSupervisorCreator(ActorRefFactory factory) {
+  synchronized public static ActorRef createSupervisorCreator(
+      ActorRefFactory factory) {
     return factory.actorOf(Props.apply(AskSupervisorCreator.class));
   }
 }
-
-// example usage
-try {
-	ActorRef supervisorCreator = SupervisedAsk.createSupervisorCreator(actorSystem);
-	Future<Object> finished = SupervisedAsk.askOf(supervisorCreator, 
-		Props.apply(SomeActor.class), message, timeout);
-	SomeResult result = (SomeResult) Await.result(finished, timeout.duration());
-} catch (Exception e) {
-	// exception propagated by supervision
-}

akka-docs/rst/java/code/docs/pattern/SupervisedAskSpec.java

@@ -0,0 +1,23 @@
+package docs.pattern;
+
+import docs.testkit.TestKitSampleTest.SomeActor;
+import scala.actors.Future;
+import actor.ActorRef;
+import actor.Props;
+
+public class SupervisedAskSpec {
+
+  public void execute() {
+    // example usage
+    try {
+      ActorRef supervisorCreator = SupervisedAsk
+          .createSupervisorCreator(actorSystem);
+      Future<Object> finished = SupervisedAsk.askOf(supervisorCreator,
+          Props.apply(SomeActor.class), message, timeout);
+      Object result = Await.result(finished,
+          timeout.duration());
+    } catch (Exception e) {
+      // exception propagated by supervision
+    }
+  }
+}

akka-docs/rst/java/howto.rst

@@ -24,7 +24,7 @@ Single-Use Actor Trees with High-Level Error Reporting
 A nice way to enter the actor world from java is the use of Patterns.ask().
 This method starts a temporary actor to forward the message and collect the result from the actor to be "asked".
 In case of errors within the asked actor the default supervision handling will take over.
-The caller of Patterns.ask() will not be notified.
+The caller of Patterns.ask() will *not* be notified.
 
 If that caller is interested in such an exception, he must make sure that the asked actor replies with Status.Failure(Throwable).
 Behind the asked actor a complex actor hierarchy might be spawned to accomplish asynchronous work.
@@ -51,6 +51,7 @@ Afterwards the actor hierarchy is stopped.
 
 Finally we are able to execute an actor and receive the results or exceptions.
 
+.. includecode:: code/docs/pattern/SupervisedAskSpec.java
 
 Template Pattern
 ================