raboof/pekko
1
0
Fork 0
Code Issues Pull requests Projects Releases 6 Packages Wiki Activity Actions 11

Replaced PushStage based Take with GraphStage #19834

Browse source 
Changes suggested by @viktorklang

Added take to binary compatibility exclude

Cleanup
This commit is contained in:
Tapio Rautonen 2016-02-28 23:14:29 +02:00
parent 65a9e0a0f9
commit 1bcc1310d2
6 changed files with 50 additions and 30 deletions
Download patch file Download diff file Expand all files Collapse all files

27
akka-stream-tests/src/test/scala/akka/stream/impl/fusing/InterpreterSpec.scala
View file

@ -14,11 +14,14 @@ class InterpreterSpec extends AkkaSpec with GraphInterpreterSpecKit {
import Supervision.stoppingDecider
/*
* These tests were writtern for the previous veryion of the interpreter, the so called OneBoundedInterpreter.
* These tests were written for the previous version of the interpreter, the so called OneBoundedInterpreter.
* These stages are now properly emulated by the GraphInterpreter and many of the edge cases were relevant to
* the execution model of the old one. Still, these tests are very valuable, so please do not remove.
*/
val takeOne = Take(1)
val takeTwo = Take(2)
"Interpreter" must {
"implement map correctly" in new OneBoundedSetup[Int](Seq(Map((x: Int) ⇒ x + 1, stoppingDecider))) {
@ -126,7 +129,7 @@ class InterpreterSpec extends AkkaSpec with GraphInterpreterSpecKit {
lastEvents() should be(Set(Cancel))
}
"implement take" in new OneBoundedSetup[Int](Seq(Take(2))) {
"implement take" in new OneBoundedSetup[Int](takeTwo) {
lastEvents() should be(Set.empty)
@ -143,10 +146,10 @@ class InterpreterSpec extends AkkaSpec with GraphInterpreterSpecKit {
lastEvents() should be(Set(OnNext(1), Cancel, OnComplete))
}
"implement take inside a chain" in new OneBoundedSetup[Int](Seq(
Filter((x: Int) ⇒ x != 0, stoppingDecider),
Take(2),
Map((x: Int) ⇒ x + 1, stoppingDecider))) {
"implement take inside a chain" in new OneBoundedSetup[Int](
Filter((x: Int) ⇒ x != 0, stoppingDecider).toGS,
takeTwo,
Map((x: Int) ⇒ x + 1, stoppingDecider).toGS) {
lastEvents() should be(Set.empty)
@ -521,9 +524,9 @@ class InterpreterSpec extends AkkaSpec with GraphInterpreterSpecKit {
} should be(true)
}
"implement take-take" in new OneBoundedSetup[Int](Seq(
Take(1),
Take(1))) {
"implement take-take" in new OneBoundedSetup[Int](
takeOne,
takeOne) {
lastEvents() should be(Set.empty)
downstream.requestOne()
@ -534,9 +537,9 @@ class InterpreterSpec extends AkkaSpec with GraphInterpreterSpecKit {
}
"implement take-take with pushAndFinish from upstream" in new OneBoundedSetup[Int](Seq(
Take(1),
Take(1))) {
"implement take-take with pushAndFinish from upstream" in new OneBoundedSetup[Int](
takeOne,
takeOne) {
lastEvents() should be(Set.empty)
downstream.requestOne()