From 18080cbb89ebdffb60678f8eb5adb2a0571480fc Mon Sep 17 00:00:00 2001
From: Roland Kuhn <rk@rkuhn.info>
Date: Thu, 17 Mar 2011 20:49:38 +0100
Subject: [PATCH] make FSMTimingSpec more deterministic

The test for repeated timer had a race condition between receiving the sixth
Tick and the Cancel message. Fix this by cancelling from within after the fifth
Tick received.
---
 .../akka/actor/actor/FSMTimingSpec.scala      | 23 ++++++++++---------
 1 file changed, 12 insertions(+), 11 deletions(-)

diff --git a/akka-actor/src/test/scala/akka/actor/actor/FSMTimingSpec.scala b/akka-actor/src/test/scala/akka/actor/actor/FSMTimingSpec.scala
index 11bd7f830c..a59785ab7a 100644
--- a/akka-actor/src/test/scala/akka/actor/actor/FSMTimingSpec.scala
+++ b/akka-actor/src/test/scala/akka/actor/actor/FSMTimingSpec.scala
@@ -16,7 +16,7 @@ class FSMTimingSpec
 
   val fsm = Actor.actorOf(new StateMachine(testActor)).start
   fsm ! SubscribeTransitionCallBack(testActor)
-  expectMsg(100 millis, CurrentState(fsm, Initial))
+  expectMsg(200 millis, CurrentState(fsm, Initial))
 
   ignoreMsg {
       case Transition(_, Initial, _) => true
@@ -43,12 +43,11 @@ class FSMTimingSpec
 
     "receive and cancel a repeated timer" in {
       fsm ! TestRepeatedTimer
-      val seq = receiveWhile(550 millis) {
+      val seq = receiveWhile(600 millis) {
         case Tick => Tick
       }
       seq must have length (5)
       within(250 millis) {
-        fsm ! Cancel
         expectMsg(Transition(fsm, TestRepeatedTimer, Initial))
         expectNoMsg
       }
@@ -95,17 +94,17 @@ object FSMTimingSpec {
 
   case class Unhandled(msg : AnyRef)
 
-  class StateMachine(tester : ActorRef) extends Actor with FSM[State, Unit] {
+  class StateMachine(tester : ActorRef) extends Actor with FSM[State, Int] {
     import FSM._
 
-    startWith(Initial, ())
+    startWith(Initial, 0)
     when(Initial) {
       case Ev(TestSingleTimer) =>
         setTimer("tester", Tick, 100 millis, false)
         goto(TestSingleTimer)
       case Ev(TestRepeatedTimer) =>
         setTimer("tester", Tick, 100 millis, true)
-        goto(TestRepeatedTimer)
+        goto(TestRepeatedTimer) using 4
       case Ev(x : FSMTimingSpec.State) => goto(x)
     }
     when(TestStateTimeout, stateTimeout = 100 millis) {
@@ -117,12 +116,14 @@ object FSMTimingSpec {
         goto(Initial)
     }
     when(TestRepeatedTimer) {
-      case Ev(Tick) =>
+      case Event(Tick, remaining) =>
         tester ! Tick
-        stay
-      case Ev(Cancel) =>
-        cancelTimer("tester")
-        goto(Initial)
+        if (remaining == 0) {
+          cancelTimer("tester")
+          goto(Initial)
+        } else {
+          stay using (remaining - 1)
+        }
     }
     when(TestUnhandled) {
       case Ev(SetHandler) =>