raboof/pekko
1
0
Fork 0
Code Issues Pull requests Projects Releases 6 Packages Wiki Activity Actions 10

=htp #16064 fail properly and early if Gzip header is corrupt

Browse source
This commit is contained in:
Johannes Rudolph 2014-10-09 13:35:27 +02:00
parent 6535f3de50
commit 13fb925fe9
2 changed files with 31 additions and 27 deletions
Download patch file Download diff file Expand all files Collapse all files

6
akka-http-tests/src/test/scala/akka/http/coding/GzipSpec.scala
View file

@ -10,7 +10,7 @@ import akka.http.util._
import HttpMethods.POST
import java.io.{ InputStream, OutputStream, ByteArrayInputStream, ByteArrayOutputStream }
import java.util.zip.{ DataFormatException, GZIPInputStream, GZIPOutputStream }
import java.util.zip.{ ZipException, DataFormatException, GZIPInputStream, GZIPOutputStream }
import akka.util.ByteString
@ -51,6 +51,10 @@ class GzipSpec extends WordSpec with CodecSpecSupport {
val ex = the[DataFormatException] thrownBy ourGunzip(corruptGzipContent)
ex.getMessage should equal("invalid literal/length code")
}
"throw early if header is corrupt" in {
val ex = the[ZipException] thrownBy ourGunzip(ByteString(0, 1, 2, 3, 4))
ex.getMessage should equal("Not in GZIP format")
}
"not throw an error if a subsequent block is corrupt" in {
pending // FIXME: should we read as long as possible and only then report an error, that seems somewhat arbitrary
ourGunzip(Seq(gzip("Hello,"), gzip(" dear "), corruptGzipContent).join) should readAs("Hello, dear ")