raboof/pekko
1
0
Fork 0
Code Issues Pull requests Projects Releases 6 Packages Wiki Activity Actions 10

add stress test, keep count of suspend/resume, and fix resulting bugs

Browse source
This commit is contained in:
Roland 2012-06-19 11:02:06 +02:00
parent 2e459f5f1d
commit 1148e20dbb
4 changed files with 401 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

42
akka-actor/src/main/scala/akka/dispatch/Mailbox.scala
View file

@ -23,12 +23,16 @@ private[akka] object Mailbox {
* the following assigned numbers CANNOT be changed without looking at the code which uses them!
*/
// primary status: only first three
// primary status
final val Open = 0 // _status is not initialized in AbstractMailbox, so default must be zero! Deliberately without type ascription to make it a compile-time constant
final val Suspended = 1 // Deliberately without type ascription to make it a compile-time constant
final val Closed = 2 // Deliberately without type ascription to make it a compile-time constant
final val Closed = 1 // Deliberately without type ascription to make it a compile-time constant
// secondary status: Scheduled bit may be added to Open/Suspended
final val Scheduled = 4 // Deliberately without type ascription to make it a compile-time constant
final val Scheduled = 2 // Deliberately without type ascription to make it a compile-time constant
// shifted by 2: the suspend count!
final val shouldScheduleMask = 3
final val shouldProcessMask = ~2
final val suspendMask = ~3
final val suspendUnit = 4
// mailbox debugging helper using println (see below)
// since this is a compile-time constant, scalac will elide code behind if (Mailbox.debug) (RK checked with 2.9.1)
@ -78,10 +82,10 @@ private[akka] abstract class Mailbox(val actor: ActorCell, val messageQueue: Mes
final def status: Mailbox.Status = Unsafe.instance.getIntVolatile(this, AbstractMailbox.mailboxStatusOffset)
@inline
final def shouldProcessMessage: Boolean = (status & 3) == Open
final def shouldProcessMessage: Boolean = (status & shouldProcessMask) == 0
@inline
final def isSuspended: Boolean = (status & 3) == Suspended
final def isSuspended: Boolean = (status & suspendMask) != 0
@inline
final def isClosed: Boolean = status == Closed
@ -100,21 +104,30 @@ private[akka] abstract class Mailbox(val actor: ActorCell, val messageQueue: Mes
/**
* set new primary status Open. Caller does not need to worry about whether
* status was Scheduled or not.
*
* @returns true if the suspend count reached zero
*/
@tailrec
final def becomeOpen(): Boolean = status match {
case Closed ⇒ setStatus(Closed); false
case s ⇒ updateStatus(s, Open | s & Scheduled) || becomeOpen()
case s ⇒
val next = if (s < suspendUnit) s else s - suspendUnit
if (updateStatus(s, next)) next < suspendUnit
else becomeOpen()
}
/**
* set new primary status Suspended. Caller does not need to worry about whether
* status was Scheduled or not.
*
* @returns true if the previous suspend count was zero
*/
@tailrec
final def becomeSuspended(): Boolean = status match {
case Closed ⇒ setStatus(Closed); false
case s ⇒ updateStatus(s, Suspended | s & Scheduled) || becomeSuspended()
case s ⇒
if (updateStatus(s, s + suspendUnit)) s < suspendUnit
else becomeSuspended()
}
/**
@ -135,11 +148,10 @@ private[akka] abstract class Mailbox(val actor: ActorCell, val messageQueue: Mes
val s = status
/*
* only try to add Scheduled bit if pure Open/Suspended, not Closed or with
* Scheduled bit already set (this is one of the reasons why the numbers
* cannot be changed in object Mailbox above)
* Scheduled bit already set
*/
if (s <= Suspended) updateStatus(s, s | Scheduled) || setAsScheduled()
else false
if ((s & shouldScheduleMask) != Open) false
else updateStatus(s, s | Scheduled) || setAsScheduled()
}
/**
@ -148,12 +160,6 @@ private[akka] abstract class Mailbox(val actor: ActorCell, val messageQueue: Mes
@tailrec
final def setAsIdle(): Boolean = {
val s = status
/*
* only try to remove Scheduled bit if currently Scheduled, not Closed or
* without Scheduled bit set (this is one of the reasons why the numbers
* cannot be changed in object Mailbox above)
*/
updateStatus(s, s & ~Scheduled) || setAsIdle()
}