raboof/pekko
1
0
Fork 0
Code Issues Pull requests Projects Releases 6 Packages Wiki Activity Actions 10

=typ initialize ActorRefResolver lazily in MiscMessageSerializer

Browse source 
Serializers are initialized early on even before the underlying untyped
ActorSystem is fully initialized. Accessing extensions might trigger
a chain of initialization that might step on uninitialized internal bits
later on.
This commit is contained in:
Johannes Rudolph 2018-01-23 16:45:45 +01:00
parent b90a1166ef
commit 0c1ee2f4a8
No known key found for this signature in database
GPG key ID: 4D293A24CCD39E19
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
akka-actor-typed/src/main/scala/akka/actor/typed/internal/MiscMessageSerializer.scala
View file

@ -14,7 +14,8 @@ import akka.serialization.{ BaseSerializer, SerializerWithStringManifest }
@InternalApi
class MiscMessageSerializer(val system: akka.actor.ExtendedActorSystem) extends SerializerWithStringManifest with BaseSerializer {
private val resolver = ActorRefResolver(system.toTyped)
// Serializers are initialized early on. `toTyped` might then try to initialize the untyped ActorSystemAdapter extension.
private lazy val resolver = ActorRefResolver(system.toTyped)
private val ActorRefManifest = "a"
def manifest(o: AnyRef): String = o match {