=clu #3517 Guard against wrong random selection

* When all weights in the map are zero total became 0, which is not
  valid in random pick. Treat this special case as empty WeightedRoutees, i.e.
  no availble targets and routing to deadLetters.

akka-actor-tests/src/test/scala/akka/util/ByteStringSpec.scala

@@ -231,7 +231,7 @@ class ByteStringSpec extends WordSpec with MustMatchers with Checkers {
     for (i ← 0 until data.length) builder.putLongPart(data(i), nBytes)(byteOrder)
 
     reference.zipWithIndex.collect({ // Since there is no partial put on LongBuffer, we need to collect only the interesting bytes
-      case (r, i) if byteOrder == ByteOrder.LITTLE_ENDIAN && i % elemSize < nBytes     ⇒ r
+      case (r, i) if byteOrder == ByteOrder.LITTLE_ENDIAN && i % elemSize < nBytes            ⇒ r
       case (r, i) if byteOrder == ByteOrder.BIG_ENDIAN && i % elemSize >= (elemSize - nBytes) ⇒ r
     }).toSeq == builder.result
   }

akka-cluster/src/main/scala/akka/cluster/routing/AdaptiveLoadBalancingRouter.scala

@@ -399,7 +399,7 @@ private[cluster] class WeightedRoutees(refs: immutable.IndexedSeq[ActorRef], sel
     buckets
   }
 
-  def isEmpty: Boolean = buckets.length == 0
+  def isEmpty: Boolean = buckets.length == 0 || buckets(buckets.length - 1) == 0
 
   def total: Int = {
     require(!isEmpty, "WeightedRoutees must not be used when empty")

akka-cluster/src/test/scala/akka/cluster/routing/WeightedRouteesSpec.scala

@@ -44,6 +44,16 @@ class WeightedRouteesSpec extends AkkaSpec(ConfigFactory.parseString("""
       intercept[IllegalArgumentException] {
         empty.total
       }
+
+      val empty2 = new WeightedRoutees(Vector(refA), a1, Map(a1 -> 0))
+      empty2.isEmpty must be(true)
+      intercept[IllegalArgumentException] {
+        empty2.total
+      }
+      intercept[IllegalArgumentException] {
+        empty2(0)
+      }
+
       val weighted = new WeightedRoutees(Vector(refA, refB, refC), a1, Map.empty)
       weighted.total must be(3)
       intercept[IllegalArgumentException] {