raboof/pekko
1
0
Fork 0
Code Issues Pull requests Projects Releases 6 Packages Wiki Activity Actions 10

Remove Scala 2.11 for Akka 2.6 (#26760)

Browse source 
* Remove Scala 2.11 for Akka 2.6

* Remove unused import

* Update akka-actor/src/main/scala-2.13/akka/compat/Future.scala

Co-Authored-By: chbatey <christopher.batey@gmail.com>

* Update akka-actor/src/main/scala-2.13/akka/compat/Future.scala

Co-Authored-By: chbatey <christopher.batey@gmail.com>

* Remove last few bits of 2.11
This commit is contained in:
Christopher Batey 2019-04-19 07:53:27 +01:00 • committed by GitHub
parent d6eb1f237c
commit 0ab7a96ae2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
22 changed files with 202 additions and 1053 deletions
Download patch file Download diff file Expand all files Collapse all files

10
CONTRIBUTING.md
View file

@ -206,7 +206,7 @@ validate binary compatibility of incoming pull requests. If your PR fails due to
an error like this:
```
[info] akka-stream: found 1 potential binary incompatibilities while checking against com.typesafe.akka:akka-stream_2.11:2.4.2 (filtered 222)
[info] akka-stream: found 1 potential binary incompatibilities while checking against com.typesafe.akka:akka-stream_2.12:2.4.2 (filtered 222)
[error] * method foldAsync(java.lang.Object,scala.Function2)akka.stream.scaladsl.FlowOps in trait akka.stream.scaladsl.FlowOps is present only in current version
[error] filter with: ProblemFilters.exclude[ReversedMissingMethodProblem]("akka.stream.scaladsl.FlowOps.foldAsync")
```
@ -439,8 +439,7 @@ Scala has proven the most viable way to do it, as long as you keep the following
1. Have methods in the `javadsl` package delegate to the methods in the Scala API, or the common internal implementation.
The Akka Stream Scala instances for example have a `.asJava` method to convert to the `akka.stream.javadsl` counterparts.
1. When using Scala `object` instances, offer a `getInstance()` method and add a sealed abstract class
(to support Scala 2.11) to get the return type. See `akka.Done` for an example.
1. When using Scala `object` instances, offer a `getInstance()` method. See `akka.Done` for an example.
1. When the Scala API contains an `apply` method, use `create` or `of` for Java users.
@ -450,9 +449,6 @@ Scala has proven the most viable way to do it, as long as you keep the following
1. Be careful to convert values within data structures (eg. for `scala.Long` vs. `java.lang.Long`, use `scala.Long.box(value)`)
1. When compiling with both Scala 2.11 and 2.12, some methods considered overloads in 2.11, become ambiguous in
2.12 as both may be functional interfaces.
1. Complement any methods with Scala collections with a Java collection version
1. Use the `akka.japi.Pair` class to return tuples
@ -474,8 +470,6 @@ Scala has proven the most viable way to do it, as long as you keep the following
both Java and Scala APIs. Make such classes `private[akka]` and also, since that becomes `public` from Java's point of
view, annotate with `@InternalApi` and add a scaladoc saying `INTERNAL API`
1. Companion objects (in Scala 2.11) cannot be accessed from Java if their companion is a trait, use an `abstract class` instead
1. Traits that are part of the Java API should only be used to define pure interfaces, as soon as there are implementations of methods, prefer
`abstract class`.